[webkit-reviews] review granted: [Bug 135277] [iOS][WK2] Do not try to hit test a null mainFrameRenderView on dynamicViewportSizeUpdate() : [Attachment 235487] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 24 18:55:14 PDT 2014
Tim Horton <thorton at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 135277: [iOS][WK2] Do not try to hit test a null mainFrameRenderView on
dynamicViewportSizeUpdate()
https://bugs.webkit.org/show_bug.cgi?id=135277
Attachment 235487: Patch
https://bugs.webkit.org/attachment.cgi?id=235487&action=review
------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235487&action=review
> Source/WebKit2/ChangeLog:11
> + There is no guarantee that the main frame have its root layer when
performing a dynamicViewportSizeUpdate(),
s/have/has/
should "layer" be "view"?
> Source/WebKit2/ChangeLog:18
> + When the hit test is not done, the position restored become a
relative in the content size.
the end of this sentence is grammatically wrong but I'm not sure the best way
to fix it and it's not important :D
More information about the webkit-reviews
mailing list