[webkit-reviews] review granted: [Bug 133963] Add knowledge of the iOS Simulator to webkitpy : [Attachment 235481] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 24 17:40:20 PDT 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 133963: Add knowledge of the iOS Simulator to webkitpy
https://bugs.webkit.org/show_bug.cgi?id=133963

Attachment 235481: Patch
https://bugs.webkit.org/attachment.cgi?id=235481&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235481&action=review


> Tools/ChangeLog:16
> +	   * Scripts/webkitpy/port/ios.py: Added.

can we call this iossimulator.py ?

> Tools/Scripts/webkitpy/port/ios.py:50
> +    ARCHITECTURES = ['x86_64', 'x86']

We should probably support 32-bit too.


More information about the webkit-reviews mailing list