[webkit-reviews] review granted: [Bug 135264] Crash when measuring a glyphs from a fallback SVG font : [Attachment 235476] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135264: Crash when measuring a glyphs from a fallback SVG font
https://bugs.webkit.org/show_bug.cgi?id=135264

Attachment 235476: Patch
https://bugs.webkit.org/attachment.cgi?id=235476&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235476&action=review


> Source/WebCore/platform/graphics/WidthIterator.cpp:127
> +	   if (iterator.run().renderingContext() && typesettingFeatures &
Kerning) {

Minor preference for parens around (typesettingFeatures & Kerning)

> Source/WebCore/platform/graphics/WidthIterator.cpp:129
> +	       // However, doing the above FIXME seems like questionable
design. Perhaps a larger refactoring of SVG fonts is necessary.

Odd comment in this context. Just reword the FIXME.