[webkit-reviews] review granted: [Bug 135221] [iOS WK2] Header bar on nytimes articles lands in the wrong place after rubberbanding : [Attachment 235473] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 135221: [iOS WK2] Header bar on nytimes articles lands in the wrong place
after rubberbanding
https://bugs.webkit.org/show_bug.cgi?id=135221

Attachment 235473: Patch
https://bugs.webkit.org/attachment.cgi?id=235473&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235473&action=review


> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:181
> +    if (scrolledNodeID == rootScrollingNodeID() && m_requestedScrollInfo) {
> +	   m_requestedScrollInfo->requestsScrollPositionUpdate = true;
> +	   m_requestedScrollInfo->requestIsProgrammaticScroll =
representsProgrammaticScroll;
> +	   m_requestedScrollInfo->requestedScrollPosition = scrollPosition;
> +    }

ouch, that's not pretty.