[webkit-reviews] review granted: [Bug 134835] CSS JIT: Implement Pseudo Element : [Attachment 235419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 24 16:30:14 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 134835: CSS JIT: Implement Pseudo Element
https://bugs.webkit.org/show_bug.cgi?id=134835

Attachment 235419: Patch
https://bugs.webkit.org/attachment.cgi?id=235419&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235419&action=review


Brilliant change. I love how good this is compared to SelectorChecker, it is
both simpler and more efficient.

> Source/WebCore/css/ElementRuleCollector.cpp:305
> +	   // FIXME: Currently a compiled selector doesn't support scrollbar /
selection's exceptional case.

Good news! Alex is looking into that! :)

> Source/WebCore/cssjit/SelectorCompiler.cpp:518
> +
> +		   // In Selectors Level 4, a pseudo element inside a
functional pseudo class is undefined (issue 7).
> +		   // Make it as matching failure until the spec clarifies this
case.
> +		   // So don't insert it to anyFragments.
> +		   if (subFragment.pseudoElementSelector)
> +		       continue;
> +

I believe it would make sense to do this check this in constructFragments() to
have :not() and :-webkit-any() behave the same way.

> LayoutTests/ChangeLog:13
> +	   * fast/selectors/pseudo-element-inside-any-expected.html: Added.
> +	   * fast/selectors/pseudo-element-inside-any.html: Added.

It would be good to explain the new behavior of :-webkit-any() here.


More information about the webkit-reviews mailing list