[webkit-reviews] review granted: [Bug 134142] Refactor our current implementation of for-in : [Attachment 235400] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 134142: Refactor our current implementation of for-in
https://bugs.webkit.org/show_bug.cgi?id=134142

Attachment 235400: Patch
https://bugs.webkit.org/attachment.cgi?id=235400&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235400&action=review


It would be really cool if you could cover some of the corner cases with stress
tests - i.e. tests that would go into JavaScriptCore/tests/stress.  I'll let
you use your judgement for that.  r=me.

> Source/JavaScriptCore/dfg/DFGClobberize.h:160
> +	   read(World);
> +	   write(World);

So, this reads+writes world because of the possibility that the structure
changed, right?  Can you add a comment to that effect?