[webkit-reviews] review granted: [Bug 135247] [MSE] High CPU usage in SampleMap::findSamplesWithinPresentationRange() with a large number of buffered samples. : [Attachment 235458] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 135247: [MSE] High CPU usage in
SampleMap::findSamplesWithinPresentationRange() with a large number of buffered
samples.
https://bugs.webkit.org/show_bug.cgi?id=135247

Attachment 235458: Patch
https://bugs.webkit.org/attachment.cgi?id=235458&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Are the samples ordered in some way? If so, we should just do a fast check for
"is the answer the last sample?" followed by a binary search. It seems like
doing a linear search through a list of media times is probably never a good
idea, since media can be hours long.