[webkit-reviews] review granted: [Bug 135215] Turn x/y to presentation attributes : [Attachment 235444] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 135215: Turn x/y to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135215

Attachment 235444: Patch
https://bugs.webkit.org/attachment.cgi?id=235444&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235444&action=review


> LayoutTests/svg/css/parse-length-expected.txt:7
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute width="100   "
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute x="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute x="100   "
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="  100"
> +CONSOLE MESSAGE: Error: Invalid value for <rect> attribute y="100   "

Why are these invalid?

> LayoutTests/svg/css/parse-length.html:12
> +description("Test that 'with' presentation attribute is parsed with CSS
presentation rules.");

width not with

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2902
> +	   // New positioning and sizing properties for SVG

Nit: missing .

> Source/WebCore/rendering/style/SVGRenderStyleDefs.h:294
> +    // Positioning and sizing properties.
> +    class StyleLayoutData : public RefCounted<StyleLayoutData> {

It's just positioning.

> Source/WebCore/svg/SVGAnimateElement.cpp:6
> + * Copyright (C) 2014 Adobe Systems Incorporated. All rights reserved.

There were no other changes in this file.

> Source/WebCore/svg/SVGFilterElement.cpp:7
> + * Copyright (C) 2014 Adobe Systems Incorporated. All rights reserved.

Or this one.