[webkit-reviews] review granted: [Bug 135229] [Cocoa] WebCore::=?UTF-8?Q?ProtectionSpace=20doesn=E2=80=99t=20preserve=20all=20NSURLProtectionSpace=20properties?=, such as the distinguishedNames array : [Attachment 235450] Make ProtectionSpace hold onto an NSURLProtectionSpace; encode/decode it if necessary

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 135229: [Cocoa] WebCore::ProtectionSpace doesn’t preserve all
NSURLProtectionSpace properties, such as the distinguishedNames array
https://bugs.webkit.org/show_bug.cgi?id=135229

Attachment 235450: Make ProtectionSpace hold onto an NSURLProtectionSpace;
encode/decode it if necessary
https://bugs.webkit.org/attachment.cgi?id=235450&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235450&action=review


> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1
> -<?xml version="1.0" encoding="utf-8"?>
> +<?xml version="1.0" encoding="utf-8"?>

:-/

> Source/WebCore/platform/network/cf/ProtectionSpaceCFNet.h:29
> +#include "ProtectionSpaceBase.h"

Please add an #if/#error somewhere here to indicate that this is a Windows only
file.

> Source/WebCore/platform/network/cocoa/ProtectionSpaceCocoa.h:58
> +    bool encodingRequiresPlatformData() const { return m_nsSpace &&
!encodingRequiresPlatformData(m_nsSpace.get()); }

!