[webkit-reviews] review granted: [Bug 135069] Sharing SharedBuffer between WebCore and ImageIO is racy and crash prone : [Attachment 235395] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 135069: Sharing SharedBuffer between WebCore and ImageIO is racy and crash
prone
https://bugs.webkit.org/show_bug.cgi?id=135069

Attachment 235395: Patch
https://bugs.webkit.org/attachment.cgi?id=235395&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235395&action=review


> Source/WebCore/platform/SharedBuffer.cpp:81
> +    , m_buffer(adoptRef(new DataBuffer))

We don't pass the size to the DataBuffer?