[webkit-reviews] review denied: [Bug 135048] Add --dry-run option to sort-export-file : [Attachment 235278] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 24 07:56:04 PDT 2014


Csaba Osztrogonác <ossy at webkit.org> has denied Nagy Renátó
<nagy.renato at stud.u-szeged.hu>'s request for review:
Bug 135048: Add --dry-run option to sort-export-file
https://bugs.webkit.org/show_bug.cgi?id=135048

Attachment 235278: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=235278&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235278&action=review


> Tools/Scripts/sort-export-file:157
>	   open OUT, ">", $exportFile or die "Could not overwrite $exportFile:
$!";
>	   print OUT $after;
>	   close OUT;

You shouldn't update the export files here.


More information about the webkit-reviews mailing list