[webkit-reviews] review granted: [Bug 135237] [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize : [Attachment 235426] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 135237: [TexMap] GraphicsLayerTextureMapper::addAnimation() box size
parameter should be FloatSize
https://bugs.webkit.org/show_bug.cgi?id=135237

Attachment 235426: Patch
https://bugs.webkit.org/attachment.cgi?id=235426&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review


> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84
> -    virtual bool addAnimation(const KeyframeValueList&, const IntSize&,
const Animation*, const String&, double);
> +    virtual bool addAnimation(const KeyframeValueList&, const FloatSize&,
const Animation*, const String&, double);

I think adding override to this delcaration is a good idea, since it has the
potential to catch these errors in the future.