[webkit-reviews] review denied: [Bug 134826] Anchor, Area and Link elements should respond to :enabled selector if they have an href attribute : [Attachment 235379] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Bruno Abinader
<bruno.d at partner.samsung.com>'s request for review:
Bug 134826: Anchor, Area and Link elements should respond to :enabled selector
if they have an href attribute
https://bugs.webkit.org/show_bug.cgi?id=134826

Attachment 235379: Patch
https://bugs.webkit.org/attachment.cgi?id=235379&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235379&action=review


Patch doesn’t apply.

> Source/WebCore/css/SelectorCheckerTestFunctions.h:67
> +    else if (isHTMLAnchorElement(element) || isHTMLAreaElement(element))
> +	   return element->isLink();

Minor style nit: We don’t do else after return.

Performance nit: Should check the isLink bit first, before looking at the the
element type, for better performance.