[webkit-reviews] review denied: [Bug 133571] [JavaScriptCore] Fix FTL on platform EFL. : [Attachment 233798] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 133571: [JavaScriptCore] Fix FTL on platform EFL.
https://bugs.webkit.org/show_bug.cgi?id=133571

Attachment 233798: Patch
https://bugs.webkit.org/attachment.cgi?id=233798&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=233798&action=review


> Source/JavaScriptCore/ftl/FTLEhFrameParser.h:21
> +/*
> +* University of Illinois/NCSA
> +* Open Source License
> +*
> +* Copyright (c) 2009-2014 by the contributors of LLVM/libc++abi project.
> +*
> +* All rights reserved.
> +*
> +* Developed by:
> +*
> +*	LLVM Team
> +*
> +*	University of Illinois at Urbana-Champaign
> +*
> +*	http://llvm.org
> +*
> +* Permission is hereby granted, free of charge, to any person obtaining a
copy of
> +* this software and associated documentation files (the "Software"), to deal
with
> +* the Software without restriction, including without limitation the rights
to
> +* use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies
> +* of the Software, and to permit persons to whom the Software is furnished
to do

This should not be a header file.  It's very strange to have headers that
define functions in the global namespace with the intention of only including
them in one .cpp file.

I would find a way to factor this out into a .cpp file, with a declared API in
a corresponding .h file.