[webkit-reviews] review granted: [Bug 135146] [ftlopt] Get rid of structure checks as a way of checking if a function is in fact a function : [Attachment 235338] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 22 20:49:42 PDT 2014


Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 135146: [ftlopt] Get rid of structure checks as a way of checking if a
function is in fact a function
https://bugs.webkit.org/show_bug.cgi?id=135146

Attachment 235338: the patch
https://bugs.webkit.org/attachment.cgi?id=235338&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235338&action=review


> Source/JavaScriptCore/dfg/DFGUseKind.cpp:42
> -	   break;
> +	   return;

i kind of wish the s/break/return/ change was separate but not enough to r- or
anything :)


More information about the webkit-reviews mailing list