[webkit-reviews] review granted: [Bug 135180] REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling : [Attachment 235320] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 135180: REGRESSION (WebKit2): Selection inside accelerated overflow:scroll
doesn't track scrolling
https://bugs.webkit.org/show_bug.cgi?id=135180

Attachment 235320: Patch
https://bugs.webkit.org/attachment.cgi?id=235320&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235320&action=review


> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:315
> +#if PLATFORM(IOS)
> +	   if (scrollingLayerPositionAction == SetScrollingLayerPosition)
> +	       m_page->editorClient()->updateSelection();
> +#endif

Can we push this #ifdef down into editorClient, giving EditorClient an
overflowScrollPositionnChanged(bool) which is not #ifdeffed, and only
implementing for iOS?

This would be better than having #if PLATFORM(IOS) in core code.