[webkit-reviews] review requested: [Bug 135178] JSDOMWindowShell leaks on pages with media elements : [Attachment 235317] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 135178: JSDOMWindowShell leaks on pages with media elements
https://bugs.webkit.org/show_bug.cgi?id=135178

Attachment 235317: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235317&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
I am somewhat concerned that other iterations over m_windowShells could trigger
a GC that modifies m_windowShells. However they are far more straightforward
than WebCore::ScriptController::clearWindowShell.

It also seems dangerous that ScriptCachedFrameData reaches directly in and
iterates ScriptController.m_windowShells.