[webkit-reviews] review granted: [Bug 135167] [CMake] Avoid building WebCore with ANGLE's OpenGL/EGL headers : [Attachment 235304] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 135167: [CMake] Avoid building WebCore with ANGLE's OpenGL/EGL headers
https://bugs.webkit.org/show_bug.cgi?id=135167

Attachment 235304: Patch
https://bugs.webkit.org/attachment.cgi?id=235304&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235304&action=review


> Source/WebCore/CMakeLists.txt:3608
> -    list(APPEND WebCore_LIBRARIES ANGLESupport)
> +    target_include_directories(ANGLESupport PRIVATE
"${THIRDPARTY_DIR}/ANGLE/include")
> +    target_link_libraries(WebCore ANGLESupport)

Why use target_link_libraries directly here instead of WebCore_LIBRARIES?