[webkit-reviews] review granted: [Bug 135143] JSLock release should only modify the AtomicStringTable if it modified in acquire : [Attachment 235264] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 22 10:24:59 PDT 2014
Pratik Solanki <psolanki at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 135143: JSLock release should only modify the AtomicStringTable if it
modified in acquire
https://bugs.webkit.org/show_bug.cgi?id=135143
Attachment 235264: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=235264&action=review
------- Additional Comments from Pratik Solanki <psolanki at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235264&action=review
Patch looks fine to me but would be good if Geoff took a look as well.
> Source/JavaScriptCore/runtime/JSLock.cpp:170
> + if (m_vm) {
Early return?
More information about the webkit-reviews
mailing list