[webkit-reviews] review denied: [Bug 135114] [GStreamer] [GTK] WebKit does not build with GStreamer 1.4 : [Attachment 235270] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 135114: [GStreamer] [GTK] WebKit does not build with GStreamer 1.4
https://bugs.webkit.org/show_bug.cgi?id=135114

Attachment 235270: Patch
https://bugs.webkit.org/attachment.cgi?id=235270&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235270&action=review


>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:46
>> +typedef struct _GstMpegtsSection GstMpegtsSection;
> 
> I'm not sure I understand this. The current code uses GstMpegTsSection, but
with gst < 1.3.90 we define GstMpegtsSection, but still using GstMpegTsSection?


Like I said in the other bug, let's just forget about 1.3.90, make sure
gstreamer-mpegts >= 1.4 is checked and only support it. 1.3.x had unstable API
that we don't want to support.