[webkit-reviews] review requested: [Bug 135074] Clicking on links while accessibility is enabled does not render as expected : [Attachment 235255] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has asked  for review:
Bug 135074: Clicking on links while accessibility is enabled does not render as
expected
https://bugs.webkit.org/show_bug.cgi?id=135074

Attachment 235255: Patch
https://bugs.webkit.org/attachment.cgi?id=235255&action=review

------- Additional Comments from Myles C. Maxfield <mmaxfield at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235255&action=review


>> Source/WebCore/ChangeLog:26
>> +	    (WebCore::AccessibilityObject::updateBackingStore): Problem 3
above.
> 
> There is no problem 3 above.

Whoops.

>> Source/WebCore/accessibility/AccessibilityObject.cpp:1440
>> +	    updateChildrenIfNecessary();
> 
> Why this hasOneRef() optimization? Is it for correctness or efficiency? Maybe
it’s explained in the mysterious “problem 3” discussion?

Efficiency. No reason to update children if we are going to die momentarily.