[webkit-reviews] review granted: [Bug 135046] Turn width/height to presentation attributes : [Attachment 235181] Same patch again to see if Win passes now.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 21 15:54:14 PDT 2014


Dean Jackson <dino at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 135046: Turn width/height to presentation attributes
https://bugs.webkit.org/show_bug.cgi?id=135046

Attachment 235181: Same patch again to see if Win passes now.
https://bugs.webkit.org/attachment.cgi?id=235181&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235181&action=review


> Source/WebCore/svg/SVGElement.cpp:544
> +    auto svgIt = cssPropertyWithSVGDOMMap.find(attributeName.impl());
> +    if (svgIt != cssPropertyWithSVGDOMMap.end())

Nit: I think if you use auto you should probably call the variable svgIterator,
or svgPropertyIterator or something.

> Source/WebCore/svg/SVGElement.h:104
> +	   // Trigger style recalculation for "elements as resource" (e.g.
referenced by feImage).
> +	   setNeedsStyleRecalc(InlineStyleChange);

Is this going to be a big performance hit?


More information about the webkit-reviews mailing list