[webkit-reviews] review denied: [Bug 135116] AX: HTML5 landmark (and related) elements should not be ignored. : [Attachment 235248] Patch (indetation fix)

[bugzilla-daemon at webkit.org]

James Craig <jcraig at apple.com> has denied  review:
Bug 135116: AX: HTML5 landmark (and related) elements should not be ignored.
https://bugs.webkit.org/show_bug.cgi?id=135116

Attachment 235248: Patch (indetation fix)
https://bugs.webkit.org/attachment.cgi?id=235248&action=review

------- Additional Comments from James Craig <jcraig at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235248&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:320
> +	   || role == FooterRole

We definitely don't want this. <footer> can be used hundreds of times per page.
For example, each post in a Facebook feed can have a footer. There's another
open bug about Footer versus ContentInfo. This would make all of them
landmarks. 

You only want footer to map to content info when it's not a descendant of an
article or section: 
http://www.w3.org/html/wg/drafts/html/CR/dom.html#sec-strong-native-semantics

Just pull this out and it'd be okay to address the rest in a separate bug.