[webkit-reviews] review granted: [Bug 132537] [iOS WK2] Turn off position:fixed behavior when the keyboard is up : [Attachment 235244] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 21 14:05:10 PDT 2014


Benjamin Poulain <benjamin at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 132537: [iOS WK2] Turn off position:fixed behavior when the keyboard is up
https://bugs.webkit.org/show_bug.cgi?id=132537

Attachment 235244: Patch
https://bugs.webkit.org/attachment.cgi?id=235244&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Looks reasonable.

Can you please force an updateVisibleContentRect from [WKContentView
_startAssistingNode:] in if the focus succeed and the AssistedNodeInformation
has insideFixedPosition? (if not you could remove insideFixedPosition
entirely).


More information about the webkit-reviews mailing list