[webkit-reviews] review granted: [Bug 135098] Web Inspector: Add esprima to the WebInspector. : [Attachment 235238] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 135098: Web Inspector: Add esprima to the WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=135098

Attachment 235238: patch
https://bugs.webkit.org/attachment.cgi?id=235238&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235238&action=review


> Source/WebInspectorUI/UserInterface/External/Esprima/esprima.js:35
> +// I delted the code that determines the context esprima is loaded in
(node.js, the browser, etc.) and replaced it with WebInspector._esprima.

We should not have "I" in a comment. Someone reading this will not know who
that refers too, and any one individual does not necessary own a file. This is
more of a "we" meaning the project / contributors as a whole.

Something like this would be sufficient:

  // WebKit Modifications:
  //   - replaced code that automatically determines Esprima execution context
(node, browser, etc.) with WebInspector._esprima

The idea here is to make it easier for the next person who updates Esprima by
documenting the changes we've made.