[webkit-reviews] review granted: [Bug 135098] Web Inspector: Add esprima to the WebInspector. : [Attachment 235176] patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 135098: Web Inspector: Add esprima to the WebInspector.
https://bugs.webkit.org/show_bug.cgi?id=135098

Attachment 235176: patch
https://bugs.webkit.org/attachment.cgi?id=235176&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235176&action=review


> Source/WebInspectorUI/ChangeLog:11
> +	   * UserInterface/External/esprima.js: Added.

Lets make a subfolder for this, like other External libraries.

    UserInterface/External/Esprima/esprima.js

> Source/WebInspectorUI/UserInterface/External/esprima.js:1
> +/*

We will want to minify this script in production builds. See how this script
handles CodeMirror:

    Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl

This could be done in a follow-up.

> Source/WebInspectorUI/UserInterface/External/esprima.js:34
> +WebInspector._esprima = {};

You should mention the edits you've made in a comment in this file. I suspect
this, and its use below, are the only changes you made.