[webkit-reviews] review denied: [Bug 135049] Division by zero in fast-dtoa.cc. : [Attachment 235127] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied peavo at outlook.com's request
for review:
Bug 135049: Division by zero in fast-dtoa.cc.
https://bugs.webkit.org/show_bug.cgi?id=135049

Attachment 235127: Patch
https://bugs.webkit.org/attachment.cgi?id=235127&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
First, I agree with Darin: this must have a test.

But even with the test, I do not believe this would be the right fix. If
divisor is zero, that likely means the input is invalid. If that happen, we
should handle that earlier in the stack (or maybe an early return in
DigitGen()). I don't think you can just ignore this loop.