[webkit-reviews] review granted: [Bug 125391] new Int32Array(new ArrayBuffer(100), 1, 1) shouldn't throw an error that says "RangeError: Byte offset and length out of range of buffer" : [Attachment 235191] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 125391: new Int32Array(new ArrayBuffer(100), 1, 1) shouldn't throw an error
that says "RangeError: Byte offset and length out of range of buffer"
https://bugs.webkit.org/show_bug.cgi?id=125391

Attachment 235191: Patch
https://bugs.webkit.org/attachment.cgi?id=235191&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235191&action=review


> Source/JavaScriptCore/runtime/ArrayBufferView.h:83
> +	   return !(size > 1 && byteOffset & (size - 1));

I know I was the one who mentioned a special case for a size of 1, but this is
not what I had in mind. The code would work fine without the size > 1
expression, so I suggest we omit it. Sorry for leading you astray.