[webkit-reviews] review granted: [Bug 135102] Crashes seen in wheel event handling : [Attachment 235187] Patch

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 135102: Crashes seen in wheel event handling
https://bugs.webkit.org/show_bug.cgi?id=135102

Attachment 235187: Patch
https://bugs.webkit.org/attachment.cgi?id=235187&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235187&action=review


> Source/WebCore/page/mac/EventHandlerMac.mm:850
> +	   // FIXME: I don't understand the lifetime guarantee for this data
member.

I think this is a great question, but it feels little oddly phrased as a
comment in the context of other WebKit comments. Maybe it's fine, but I think
you could also just have:

FIXME: What prevents us from deleting this scrollable container while still
holding a pointer to it?