[webkit-reviews] review granted: [Bug 134980] ES6: Implement Math.sign() : [Attachment 235183] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 20 08:45:45 PDT 2014


Darin Adler <darin at apple.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 134980: ES6: Implement Math.sign()
https://bugs.webkit.org/show_bug.cgi?id=134980

Attachment 235183: Patch
https://bugs.webkit.org/attachment.cgi?id=235183&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
To be thorough may also later want to add test cases to show that:

1) Extra arguments are ignored.
2) Calling with no arguments yields NaN, no exception is thrown.
3) Throwing an exception in valueOf works properly, no crash.


More information about the webkit-reviews mailing list