[webkit-reviews] review granted: [Bug 134946] [Win] Fix Assert when handling Legible Output callbacks : [Attachment 235094] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 134946: [Win] Fix Assert when handling Legible Output callbacks
https://bugs.webkit.org/show_bug.cgi?id=134946

Attachment 235094: Patch
https://bugs.webkit.org/attachment.cgi?id=235094&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235094&action=review


review+ if you can get it to compile on EWS and bots and such

>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:1533
> +    RetainPtr<CFArrayRef> subtypes = createLegibleOutputSubtypes();
> +    m_legibleOutput =
adoptCF(AVCFPlayerItemLegibleOutputCreateWithMediaSubtypesForNativeRepresentati
on(kCFAllocatorDefault, subtypes.get()));

Not sure you really even need the local variable here. Putting
createLegibleOutputSubtypes right into the expression might make the line
excessively long, but otherwise it seems like an improvement.