[webkit-reviews] review granted: [Bug 134968] Move ExceptionCodeDescription.h into the files that actually need it : [Attachment 235038] more includes2

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryuan Choi <ryuan.choi at samsung.com>'s
request for review:
Bug 134968: Move ExceptionCodeDescription.h into the files that actually need
it
https://bugs.webkit.org/show_bug.cgi?id=134968

Attachment 235038: more includes2
https://bugs.webkit.org/attachment.cgi?id=235038&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235038&action=review


> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1555
> +    $implIncludes{"ExceptionCodeDescription.h"} = 1;

What port is this file for? I believe the WebKit1 GTK port is gone from the
tree now, so I think that means this entire file is now obsolete, along with
the WebCore/bindings/gobject and WebCore/bindings/scripts/test/GObject
directories.

Another way to put this is: How did you test this change? I don’t see any
changes to the expected results for gobject in
WebCore/bindings/scripts/test/GObject, so I think the bindings tests will start
failing.