[webkit-reviews] review requested: [Bug 134860] Make improvements to Type Profiling : [Attachment 235172] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 19 13:56:11 PDT 2014


Saam Barati <sbarati at apple.com> has asked  for review:
Bug 134860: Make improvements to Type Profiling
https://bugs.webkit.org/show_bug.cgi?id=134860

Attachment 235172: patch
https://bugs.webkit.org/attachment.cgi?id=235172&action=review

------- Additional Comments from Saam Barati <sbarati at apple.com>
I improved the API between the inspector and JSC. We no longer send one huge
string to the inspector. We now send structured data that represents the type
information that JSC has collected. I've also created a beginning
implementation 
of a type lattice that allows us to resolve a display name for a type that
consists of a single word.

I created a data structure that knows which functions have executed. This
solves the bug where types inside an un-executed function will resolve
to the type of the enclosing expression of that function. This data
structure may also be useful later if the inspector chooses to create a UI
around showing which functions have executed.

Better type information is gathered for objects. StructureShape now
represents an object's prototype chain.  StructureShape also collects
the constructor name for an object.

Expression ranges are now zero indexed.

Removed some extraneous methods.


More information about the webkit-reviews mailing list