[webkit-reviews] review denied: [Bug 135074] Clicking on links while accessibility is enabled does not render as expected : [Attachment 235154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 18 22:25:22 PDT 2014


chris fleizach <cfleizach at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 135074: Clicking on links while accessibility is enabled does not render as
expected
https://bugs.webkit.org/show_bug.cgi?id=135074

Attachment 235154: Patch
https://bugs.webkit.org/attachment.cgi?id=235154&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235154&action=review


> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:-2766
> -	       return nil;

It looks like this is causing the test regressions. a bunch of tests except a
nil. 

I think it might be good to have this in a different patch if possible, so that
we can have a very focused patch just on updateBackingStore() issue


More information about the webkit-reviews mailing list