[webkit-reviews] review granted: [Bug 135083] Perf dashboard shouldn't show the full git hash : [Attachment 235167] Fixes the bug

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 135083: Perf dashboard shouldn't show the full git hash
https://bugs.webkit.org/show_bug.cgi?id=135083

Attachment 235167: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=235167&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235167&action=review


> Websites/perf.webkit.org/public/js/helper-classes.js:101
> +		   formattedCurrentHash = currentRevision.substring(0, 8);

formattedCurrentHash = currentRevision[:8] ?

> Websites/perf.webkit.org/public/js/helper-classes.js:103
> +		       labelForThisRepository = previousRevision.substring(0,
8) + '..' + formattedCurrentHash;

ditto for substring