[webkit-reviews] review granted: [Bug 135072] [iOS] Tapping "Allow Website" on a restricted page does not bring up the keypad : [Attachment 235149] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 135072: [iOS] Tapping "Allow Website" on a restricted page does not bring
up the keypad
https://bugs.webkit.org/show_bug.cgi?id=135072

Attachment 235149: Patch
https://bugs.webkit.org/attachment.cgi?id=235149&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235149&action=review


r=me

> Source/WebCore/platform/mac/ContentFilterMac.mm:250
> +    @try {
> +	   if ([getWebFilterEvaluatorClass()
conformsToProtocol:@protocol(NSSecureCoding)])
> +	       contentFilter.m_platformContentFilter = (WebFilterEvaluator
*)[unarchiver decodeObjectOfClass:getWebFilterEvaluatorClass()
forKey:platformContentFilterKey];
> +	   return true;
> +    } @catch (NSException *exception) {

Do we really want to return true here if we fall through the if statement? 
Seems like we'd want something like this:

	if ([getWebFilterEvaluatorClass()
conformsToProtocol:@protocol(NSSecureCoding)]) {
	    contentFilter.m_platformContentFilter = (WebFilterEvaluator
*)[unarchiver decodeObjectOfClass:getWebFilterEvaluatorClass()
forKey:platformContentFilterKey];
	    return true;
	}