[webkit-reviews] review granted: [Bug 135057] Add 'analyze' target to the Makefiles : [Attachment 235150] Updated patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Dana Burkart
<dburkart at apple.com>'s request for review:
Bug 135057: Add 'analyze' target to the Makefiles
https://bugs.webkit.org/show_bug.cgi?id=135057

Attachment 235150: Updated patch
https://bugs.webkit.org/attachment.cgi?id=235150&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235150&action=review


r=me

> Makefile.shared:28
>  
> +

Unintentional blank lined added?

> Makefile.shared:41
> +analyze:
> +	$(SCRIPTS_PATH)/set-webkit-configuration --release

It would be nice if we could support analyze with --debug builds as well. Maybe
add a STYLE=debug argument to the make command such that unset STYLE defaults
to 'release', but lets you override to 'debug'.

This can be added later, though.