[webkit-reviews] review granted: [Bug 135058] Take navigation snapshots whenever the current back-forward item is going to change : [Attachment 235134] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 18 12:37:40 PDT 2014


mitz at webkit.org <mitz at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 135058: Take navigation snapshots whenever the current back-forward item is
going to change
https://bugs.webkit.org/show_bug.cgi?id=135058

Attachment 235134: patch
https://bugs.webkit.org/attachment.cgi?id=235134&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235134&action=review


> Source/WebCore/loader/HistoryController.cpp:882
> +    m_frame.loader().client().willChangeCurrentHistoryItem();

Do we need to call this if we end up changing just the provisional item?


More information about the webkit-reviews mailing list