[webkit-reviews] review denied: [Bug 119044] [Win] Crash after plugin is unloaded. : [Attachment 235126] Patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has denied peavo at outlook.com's request
for review:
Bug 119044: [Win] Crash after plugin is unloaded.
https://bugs.webkit.org/show_bug.cgi?id=119044

Attachment 235126: Patch
https://bugs.webkit.org/attachment.cgi?id=235126&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
While I'm not familiar with this particular issue, this fix is incorrect. We
intentionally do not finalize WeakImpls eagerly. This would be a big regression
in GC pause times. 

It is generally not OK to depend upon finalization of WeakImpls happening
within any finite amount of time. The correct solution is probably something
along the lines of "don't delete anything that the finalizer depends on until
the finalizer runs".