[webkit-reviews] review granted: [Bug 135022] Crash in ServicesOverlayController::~ServicesOverlayController : [Attachment 235090] Patch v1

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 135022: Crash in ServicesOverlayController::~ServicesOverlayController
https://bugs.webkit.org/show_bug.cgi?id=135022

Attachment 235090: Patch v1 
https://bugs.webkit.org/attachment.cgi?id=235090&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235090&action=review


> Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:-86
> -	   m_webPage->uninstallPageOverlay(m_servicesOverlay,
PageOverlay::FadeMode::DoNotFade);

you should assert that your back pointer was nulled out (and let it be nulled
out! fix the early return in willMoveToWebPage).