[webkit-reviews] review denied: [Bug 134970] ASSERTION FAILED: listNode in WebCore::RenderListItem::updateListMarkerNumbers : [Attachment 235064] Proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Nagy Renátó
<nagy.renato at stud.u-szeged.hu>'s request for review:
Bug 134970: ASSERTION FAILED: listNode in
WebCore::RenderListItem::updateListMarkerNumbers
https://bugs.webkit.org/show_bug.cgi?id=134970

Attachment 235064: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=235064&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235064&action=review


> Source/WebCore/rendering/RenderListItem.cpp:113
> +    if (!firstNode)
> +	   firstNode = &listItem->element();

This fix is not right. I don’t think the element itself should be returned as
the list. The enclosingList function should not return something that would
return false from isList.

This function is allowed to return null if there is no enclosing list. The fix
should be at the call sites, not here in this function.