[webkit-reviews] review granted: [Bug 135011] CSS JIT: Clean up return path : [Attachment 235054] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 135011: CSS JIT: Clean up return path
https://bugs.webkit.org/show_bug.cgi?id=135011

Attachment 235054: Patch
https://bugs.webkit.org/attachment.cgi?id=235054&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235054&action=review


This looks correct to me.

> Source/WebCore/cssjit/SelectorCompiler.cpp:1193
> +    StackAllocator::StackReference baselineStackReference;

I think "baseline" is a little too generic for the name. One could think it is
the top of the stack for this function.

What about startOfDiscardableStack, temporaryStackBase, ... or something like
that?

> Source/WebCore/cssjit/StackAllocator.h:156
> +    void popAndDiscardUpToBaseline()
> +    {
> +	   if (!m_offsetFromTop)
> +	       return;
> +	  
m_assembler.addPtr(JSC::MacroAssembler::TrustedImm32(m_offsetFromTop),
JSC::MacroAssembler::stackPointerRegister);
> +	   m_offsetFromTop = 0;
> +    }
> +

This is unused.