[webkit-reviews] review granted: [Bug 134674] [EFL][WK2] Add a "focus, notfound" signal. : [Attachment 235055] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 23:38:51 PDT 2014


Gyuyoung Kim <gyuyoung.kim at webkit.org> has granted Sanghyup Lee
<sh53.lee at samsung.com>'s request for review:
Bug 134674: [EFL][WK2] Add a "focus,notfound" signal.
https://bugs.webkit.org/show_bug.cgi?id=134674

Attachment 235055: Patch
https://bugs.webkit.org/attachment.cgi?id=235055&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=235055&action=review


> Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:328

> +    Evas* evas = evas_object_evas_get(m_webView);

It would be good if you add ASSERT(evas).


More information about the webkit-reviews mailing list