[webkit-reviews] review granted: [Bug 134990] Need FTL implementation of SkipTopScope : [Attachment 235021] [ftlopt] Added SkipTopScope coverage to FTL

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Matthew Mirman
<mmirman at apple.com>'s request for review:
Bug 134990: Need FTL implementation of SkipTopScope
https://bugs.webkit.org/show_bug.cgi?id=134990

Attachment 235021: [ftlopt] Added SkipTopScope coverage to FTL
https://bugs.webkit.org/attachment.cgi?id=235021&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235021&action=review


r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3421
> +	       m_out.isZero64(
m_out.load64(addressFor(machineActivationRegister)))

No space after the paren here.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3423
> +	       , unsure(isNull)
> +	       , unsure(notNull));

These two can probably go on the same line.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3431
> +	   setJSValue(m_out.phi(m_out.intPtr, top,next));

Space after "top".