[webkit-reviews] review granted: [Bug 134989] Don't send geolocation permission requests when the page is not visible : [Attachment 235017] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 134989: Don't send geolocation permission requests when the page is not
visible
https://bugs.webkit.org/show_bug.cgi?id=134989

Attachment 235017: Patch
https://bugs.webkit.org/attachment.cgi?id=235017&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235017&action=review


r+ with comments

> Source/WebCore/Modules/geolocation/GeolocationController.cpp:48
> +    // NOTE: We don't have to remove ourselves 

Incomplete comment? "… from the Page's list of ViewStateChangeObservers"?

> Source/WebCore/Modules/geolocation/GeolocationController.h:68
> +    Page* m_page;

Should this be Page* or Page&?

> Source/WebCore/Modules/geolocation/GeolocationController.h:81
> +    // While in the "prerender" visibility state, we pend permission
requests.

Comment is now incorrect, "While page is hidden" / "While page is not visible"