[webkit-reviews] review granted: [Bug 134988] DFG Flush(SetLocal) store elimination is overzealous in the presence of nodes that have no effects but may throw : [Attachment 235014] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 134988: DFG Flush(SetLocal) store elimination is overzealous in the
presence of nodes that have no effects but may throw
https://bugs.webkit.org/show_bug.cgi?id=134988

Attachment 235014: the patch
https://bugs.webkit.org/attachment.cgi?id=235014&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=235014&action=review


r=me

> Source/JavaScriptCore/dfg/DFGCSEPhase.cpp:970
>	   // Be safe in release mode.

This comment doesn't make sense any more.