[webkit-reviews] review denied: [Bug 134674] [EFL][WK2] Add a "focus, control, handover" signal. : [Attachment 234990] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at webkit.org> has denied Sanghyup Lee
<sh53.lee at samsung.com>'s request for review:
Bug 134674: [EFL][WK2] Add a "focus,control,handover" signal.
https://bugs.webkit.org/show_bug.cgi?id=134674

Attachment 234990: Patch
https://bugs.webkit.org/attachment.cgi?id=234990&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=234990&action=review


> Source/WebKit2/UIProcess/API/efl/ewk_view.h:42
> + * - "focus,control,handover", Ewk_Focus_Direction*: reports that user can
take the focus from the ewk_view because

This signal is to notify if focus direction is changed.
EWK_FOCUS_DIRECTION_FORWARD or EWK_FOCUS_DIRECTION_BACKWARD. This signal name
doesn't contain meaning for user. "focus,direction,changed" looks better.
Besides your description regarding "handover focus control bla bla..." is
redundant. We only need to explain what does this signal report.