[webkit-reviews] review denied: [Bug 134966] [CSS Grid Layout] Add element.style coverage for grid-auto-flow : [Attachment 234983] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 16 02:25:30 PDT 2014


Sergio Villar Senin <svillar at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 134966: [CSS Grid Layout] Add element.style coverage for grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=134966

Attachment 234983: Patch
https://bugs.webkit.org/attachment.cgi?id=234983&action=review

------- Additional Comments from Sergio Villar Senin <svillar at igalia.com>
I agree with the patch but now that I see the test I think it's time to
creating something like testGridDefinitionsSetJSValues() but for grid auto
flow. It'd be something like checkGridDefinitionsSetJSValues() but very
simplified:
{
create node
set style
match result with expected result passed as argument
remove node
}


More information about the webkit-reviews mailing list