[webkit-reviews] review granted: [Bug 134946] [Win] Fix Crash when handling Legible Output callbacks : [Attachment 234961] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 134946: [Win] Fix Crash when handling Legible Output callbacks
https://bugs.webkit.org/show_bug.cgi?id=134946

Attachment 234961: Patch
https://bugs.webkit.org/attachment.cgi?id=234961&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234961&action=review


Thanks Brent!

>
Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundation
CF.cpp:1534
> +    RetainPtr<CFArrayRef> subtypes = createLegibleOutputSubtypes();

I think you want to adoptCF(createLegibleOutputSubtypes()) because the array
already has a ref count of 1.