[webkit-reviews] review granted: [Bug 134916] Clean up image subsampling code, make it less iOS-specific : [Attachment 234906] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 134916: Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916

Attachment 234906: Patch
https://bugs.webkit.org/attachment.cgi?id=234906&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=234906&action=review


> Source/WebCore/platform/graphics/BitmapImage.cpp:390
> +    // We may have cached a frame with a higher subsampling level, in which
case we need to
> +    // re-decode with a lower level.
> +    if (index < m_frames.size() && m_frames[index].m_frame &&
subsamplingLevel < m_frames[index].m_subsamplingLevel) {
>	   // If the image is already cached, but at too small a size,
re-decode a larger version.

The wording around higher and lower, smaller and larger is often confusing.
Maybe the comment should be "higher subsampling level (smaller image)"?

And, the second comment here mostly duplicates the comment you added.

> Source/WebCore/platform/graphics/BitmapImage.cpp:395
> +	   WTFLogAlways("BitmapImage %p frameAtIndex recaching, m_decodedSize
now %u (size change %d)", this, m_decodedSize, sizeChange);

Always? Why not add a new logging channel?